On Thu, Feb 12, 2015 at 8:15 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 11.02.2015 23:23, Marek Olšák wrote: >> From: Marek Olšák <marek.ol...@amd.com> >> >> Cc: 10.4 <mesa-sta...@lists.freedesktop.org> >> --- >> src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c >> b/src/gallium/drivers/radeonsi/si_state_shaders.c >> index 27ccc8e..dea99ea 100644 >> --- a/src/gallium/drivers/radeonsi/si_state_shaders.c >> +++ b/src/gallium/drivers/radeonsi/si_state_shaders.c >> @@ -662,8 +662,10 @@ bcolor: >> } >> >> if (j == vsinfo->num_outputs) { >> - /* No corresponding output found, load defaults into >> input */ >> - tmp |= S_028644_OFFSET(0x20); >> + /* No corresponding output found, load defaults into >> input. >> + * Don't set any other bits. >> + * (FLAT_SHADE=1 completely changes behavior) */ >> + tmp = S_028644_OFFSET(0x20); >> } >> >> si_pm4_set_reg(pm4, >> > > Does this fix any known user visible bugs, or why the stable tag?
I think it's possible to hang the GPU by setting (FLAT_SHADE | OFFSET(0x20)) if the varying doesn't exist. I haven't tested the hang myself though. There is no known bug. Marek > > > Patches 1 and 4 are > > Reviewed-by: Michel Dänzer <michel.daen...@amd.com> > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev