On Thu, Feb 12, 2015 at 4:33 AM, Tapani Pälli <tapani.pa...@intel.com> wrote: > Current implementation allowed usage of unsized type texture GL_FLOAT > and GL_HALF_FLOAT as a render target as this was 'expected behavior' by > WEBGL_oes_texture_float and is also allowed by the oes-texture-float > WebGL test. However this broke some ES3 conformance tests that do not > accept such behavior. Patch sets such an fbo incomplete as expected by > the ES3 conformance tests. Textures with sized types like RGBA32F will > still continue to work as render targets. > > Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88905 > --- > src/mesa/main/fbobject.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index dae9d4e..fee7342 100644 > --- a/src/mesa/main/fbobject.c > +++ b/src/mesa/main/fbobject.c > @@ -781,6 +781,17 @@ test_attachment_completeness(const struct gl_context > *ctx, GLenum format, > att->Complete = GL_FALSE; > return; > } > + /* OES_texture_float allows creation and use of floating point > + * textures with GL_FLOAT, GL_HALF_FLOAT but it does not allow > + * these textures to be used as a render target, this is done via > + * GL_EXT_color_buffer(_half)_float with set of new sized types. > + */ > + if (_mesa_is_gles(ctx) && (texImage->TexObject->_IsFloat || > + texImage->TexObject->_IsHalfFloat)) {
Indent this line to match with the ( around the || statement on the previous line. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
