On Thu, Feb 5, 2015 at 4:02 AM, Ian Romanick <i...@freedesktop.org> wrote: > On 01/24/2015 05:46 AM, Vinson Lee wrote: >> Fix build error. >> >> CCLD libGL.la >> libglapi.a(glapi_libglapi_la-glapi_gentable.o): In function >> `__glapi_gentable_NoOp': >> glapi_gentable.c:76: undefined reference to `backtrace' >> >> Signed-off-by: Vinson Lee <v...@freedesktop.org> >> --- >> src/mapi/glapi/gen/gl_gentable.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/mapi/glapi/gen/gl_gentable.py >> b/src/mapi/glapi/gen/gl_gentable.py >> index 06a5ebf..fb578e3 100644 >> --- a/src/mapi/glapi/gen/gl_gentable.py >> +++ b/src/mapi/glapi/gen/gl_gentable.py >> @@ -42,7 +42,7 @@ header = """/* GLXEXT is the define used in the xserver >> when the GLX extension i >> #endif >> >> #if (defined(GLXEXT) && defined(HAVE_BACKTRACE)) \\ >> - || (!defined(GLXEXT) && defined(DEBUG) && !defined(__CYGWIN__) && >> !defined(__MINGW32__) && !defined(__OpenBSD__) && !defined(__NetBSD__) && >> !defined(__DragonFly__)) >> + || (!defined(GLXEXT) && defined(DEBUG) && !defined(__CYGWIN__) && >> !defined(__MINGW32__) && !defined(__OpenBSD__) && !defined(__NetBSD__) && >> !defined(__DragonFly__) && !defined(__FreeBSD__)) >> #define USE_BACKTRACE >> #endif > > It seems weird that we need all the BSDs in this check. Is configure > setting HAVE_BACKTRACE mistakenly? Or is this logic just broken? Does > > #if defined(HAVE_BACKTRACE) && (defined(GLXEXT) || defined(DEBUG)) > > work everywhere? >
Yes, it works. I tested FreeBSD and MinGW builds. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
