Matt Turner <matts...@gmail.com> writes: > On Fri, Feb 20, 2015 at 12:20 PM, Brian Paul <bri...@vmware.com> wrote: >> Fixes xlib driver build after e8c5cbfd921680c. >> --- >> src/mesa/drivers/x11/Makefile.am | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/mesa/drivers/x11/Makefile.am >> b/src/mesa/drivers/x11/Makefile.am >> index 76a7cd4..c0596f8 100644 >> --- a/src/mesa/drivers/x11/Makefile.am >> +++ b/src/mesa/drivers/x11/Makefile.am >> @@ -30,6 +30,8 @@ AM_CPPFLAGS = \ >> -I$(top_srcdir)/src/mapi \ >> -I$(top_srcdir)/src/mesa \ >> -I$(top_srcdir)/src \ >> + -I$(top_srcdir)/src/gallium/include \ >> + -I$(top_srcdir)/src/gallium/auxiliary \ > > I really dislike including these directories in a bunch of non-Gallium > places. I should have said so more strongly when the patch went by. > > I'm not sure whether I want to spend my time to fix this the right way or > what. > > I guess just go ahead and commit this until something better comes along.
I'm sympathetic, it's just the feeling of "if I can't get incremental changes towards sharing, we'll never get anywhere and we'll be stuck with this code duplication we've had for the last 5 years". p_compiler.h looks like something we should be able to get out into util/, at which point we could drop these include dirs. It's on my list still, but I do really want to land my NIR work.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
