On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund <kusmab...@gmail.com> wrote: > On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner <matts...@gmail.com> wrote: >> On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul <bri...@vmware.com> wrote: >>> Should be defined in math.h. If not, we can add them to c99_math.h >> >> And FWIW, the MSDN page [0] says that if you define _USE_MATH_DEFINES >> before including math.h, these will be defined for you. Not sure what >> versions of MSVC that applies to. >> >> [0] https://msdn.microsoft.com/en-us/library/4hwaceh6.aspx > > That link says "Visual Studio 2013", but roughly the same message is > also in the Visual Studio .NET 2003 docs (available through the "Other > Versions"-selector at the top). > > IIRC, this has been the case since VC6, but we probably don't care > about that old toolchains.
By the way, it seems we already define _USE_MATH_DEFINES, at least here: http://cgit.freedesktop.org/mesa/mesa/tree/scons/gallium.py?id=9db7b12cb283b915865d99d2fd3356af0662a18e#n328 But do we always build for MSVC with SCons, and with gallium? If so, it seems this patch is OK from a MSVC's point of view. But perhaps it's worth a mention in the commit-message? _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
