On Thursday, March 19, 2015 06:43:07 PM Neil Roberts wrote: > The places that were checking whether 3-source instructions are > supported have now been combined into a small helper function. This > will be used in the next patch to add an additonal restriction. > > Based on a patch by Kenneth Graunke. > > --- > > Matt's review for v1 of this patch was conditional based on moving the > call to brw_instruction_supports_simd16 into the switch statement. I > went ahead and made this change in order to try and unblock this > patch. However if we are only calling this function inside the case > values I think it no longer makes sense to have another switch > on the opcode inside the new function. Instead I've changed the > function to just handle deciding whether 3-source SIMD16 instructions > are allowed and left the previous per-instruction specifics about > whether general SIMD16 is allowed as they were. I think it is a bit > cleaner this way. > > I also noticed that v1 of the patch didn't have a case for the BFE > instruction so it wouldn't be broken down. I think that is a good > indication that it's better to keep the handling for each instruction > in a single place.
Looks good to me - thanks Neil! Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
