On Fri, Mar 20, 2015 at 1:37 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, Mar 20, 2015 at 1:12 PM, Matt Turner <matts...@gmail.com> wrote: >> On Fri, Mar 20, 2015 at 11:24 AM, Jason Ekstrand <ja...@jlekstrand.net> >> wrote: >>> - emit(MOV(result, masked)); >>> + emit(MOV(retype(result, BRW_REGISTER_TYPE_D), masked)); >> >> This hunk isn't necessary. masked is vgrf(glsl_type::int_type). > > This hunk retypes result, not masked.
Oh, yeah. But result is set at the top of the function like this: fs_reg result = get_nir_dest(instr->dest.dest); result.type = brw_type_for_nir_type(nir_op_infos[instr->op].output_type); Isn't that sufficient? We're only going to be resolving things that were bool-typed to begin with, which should mean that the other changes in this patch handled it. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
