On Friday, April 24, 2015 04:33:00 PM Jordan Justen wrote: > v2: > * Do more work at the visitor level. g0 is loaded and sent to the > generator now. > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > --- > src/mesa/drivers/dri/i965/brw_fs.h | 1 + > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.h > b/src/mesa/drivers/dri/i965/brw_fs.h > index 4e17d44..b1e65cd 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs.h > +++ b/src/mesa/drivers/dri/i965/brw_fs.h > @@ -387,6 +387,7 @@ public: > bool use_2nd_half = false); > void emit_fb_writes(); > void emit_urb_writes(); > + void emit_cs_terminate(); > > void emit_shader_time_begin(); > void emit_shader_time_end(); > diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > index 11f38c2..ba8b811 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > @@ -4154,6 +4154,25 @@ fs_visitor::resolve_ud_negate(fs_reg *reg) > *reg = temp; > } > > +void > +fs_visitor::emit_cs_terminate() > +{ > + assert(brw->gen >= 7); > + > + /* We are getting the thread ID from the compute shader header */ > + assert(stage == MESA_SHADER_COMPUTE); > + > + /* Copy g0 for the message payload */
Perhaps add a comment like: /* We can't directly send from g0, since sends with EOT have to use * g112-127. So, copy it to a virtual register, The register allocator * will make sure it uses the appropriate register range. */ I was going to suggest sending from g0, but I'm guessing this is why you don't. (I wonder if it's really necessary for compute...seems wise to do for now though...) Patches 1-9 are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> > + struct brw_reg g0 = retype(brw_vec8_grf(0, 0), BRW_REGISTER_TYPE_UD); > + fs_reg payload = fs_reg(GRF, alloc.allocate(1), BRW_REGISTER_TYPE_UD); > + fs_inst *inst = emit(MOV(payload, g0)); > + inst->force_writemask_all = true; > + > + /* Send a message to the thread spawner to terminate the thread. */ > + inst = emit(CS_OPCODE_CS_TERMINATE, reg_undef, payload); > + inst->eot = true; > +} > + > /** > * Resolve the result of a Gen4-5 CMP instruction to a proper boolean. > * >
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev