> Extra space between . and "
Fix I will
> Extra space before .
Fix I will
> Also, if anyone is ever grepping for MAX_FRAMEBUFFER_SAMPLES, they won't find
> this. I'd move the whole word to the next line.
Ok.
> + *
> + * The same requirements are also in place for GL 4.5,
> + * Section 9.4.1 "Framebuffer Attachment Completeness", pg 310-311
> + *
> + * However, this is a tighter restriction than previous version of GL.
> + * In interest of better compatibility, we will not enforce these
> + * restrictions.
> + */
> Comment at the end of a block like this looks strange. I'm not sure what it's
> commenting on.
The purpose of the comment block is to list what the extension and GL4.5 add to
the requirements for FBO happiness. The last sentence is writing out *now*
that these added requirements, if enforced, risk breaking older applications
and stating that the extra requirements will not be enforced. Would it be
helpful at the top of the comment block to say
"GL4.5/GL_ARB_framebuffer_no_attachments" added these requirements?
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
