On Mon, Jul 6, 2015 at 7:55 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: >> >> + } else >> >> + if (!vb->buffer) { >> > >> > Should the else and if be on the same line? >> >> The general style elsewhere is to do it in this weird way. Can't say >> I'm a big fan, but I prefer consistency. >> >> I'd happily take a change that undid that oddity. >> > > Odd, okay.
Its one advantage is it allows one to easily remove clauses either with #if or with comments on a line level without editing other lines. However that's a pretty rare occurrence. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev