On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt <[email protected]> wrote:
> Matt Turner <[email protected]> writes:
>
>> On Fri, Jul 17, 2015 at 10:17 AM, Emil Velikov <[email protected]> 
>> wrote:
>>> Cc: Eric Anholt <[email protected]>
>>> Signed-off-by: Emil Velikov <[email protected]>
>>> ---
>>>  src/util/tests/hash_table/Makefile.am | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/src/util/tests/hash_table/Makefile.am 
>>> b/src/util/tests/hash_table/Makefile.am
>>> index 04a77e3..0c99e7b 100644
>>> --- a/src/util/tests/hash_table/Makefile.am
>>> +++ b/src/util/tests/hash_table/Makefile.am
>>> @@ -38,7 +38,6 @@ TESTS = \
>>>         null_destroy \
>>>         random_entry \
>>>         remove_null \
>>> -       replacement \
>>> -       $()
>>> +       replacement
>>
>> To get the benefit of $() without some unknown incompatibility, pixman
>> uses $(NULL) which of course relies on not having a variable named
>> NULL.
>>
>> I might suggest that instead of removing them, but I'm not much
>> opposed to removing them either.
>
> I do really like having a terminator on these lists.  I find that
> without them, I'll end up copy-and-pasting the wrong thing and missing
> the trailing backslash on a line.

Also makes diffs easier to read since you don't have spurious changes
which just add a \ .
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to