Marek Olšák wrote on 28.07.2015 21:42: > On Tue, Jul 28, 2015 at 6:35 PM, Kai Wasserbäch > <k...@dev.carbon-project.org> wrote: >> Marek Olšák wrote on 28.07.2015 12:05: >>> From: Marek Olšák <marek.ol...@amd.com> >>> >>> --- >>> src/gallium/auxiliary/util/u_debug.c | 8 ++++---- >>> src/gallium/auxiliary/util/u_debug.h | 6 +++--- >>> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> The receiving variables in the callers should probably be fixed up as well, >> right? Most of them seem to be unsigned long or just unsigned. (E.g. in >> debug_flags in r600_common_screen is an unsigned) >> But maybe that can be ignored? >> >> Though somebody with deeper knowledge of the code should give you a R-b, you >> can >> have mine, for what it is worth, with the callers fixed: >> Reviewed-by: Kai Wasserbäch <k...@dev.carbon-project.org> > > The type of r600_common_screen::debug_flags is changed by a later patch. > > I don't think the callers need updating if they don't use the higher > bits. The behavior remains the same. For radeon, the first patch using > the higher bits updates the type as well.
Ok, I would have done it in this patch. Anyway, after your explanation your patch seems fine as is. Cheers, Kai
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
