On Saturday, August 01, 2015 05:43:26 PM Emil Velikov wrote: > On 6 July 2015 at 21:40, Kenneth Graunke <kenn...@whitecape.org> wrote: > > On Monday, July 06, 2015 12:18:18 PM Matt Turner wrote: > >> On Mon, Jul 6, 2015 at 9:55 AM, Kenneth Graunke <kenn...@whitecape.org> > >> wrote: > >> > It looks like this was forgotten in commit 3c9dc2d31b80fc73bffa1f40a > >> > (i965: Make a brw_stage_prog_data for storing the SURF_INDEX > >> > information.) In other words, it's been missing since we moved to > >> > dynamic binding table slot assignments. > >> > >> Author: Eric Anholt <e...@anholt.net> > >> AuthorDate: Wed Oct 2 14:07:40 2013 -0700 > >> CommitDate: Tue Oct 15 10:18:42 2013 -0700 > >> > >> Dang. > >> > >> How did you find this? > > > > After reading Eero's latest performance analysis observations, I decided > > to try marking render targets uncached (MOCS = UC) when blending and > > logic ops (i.e. things that cause render target reads) are disabled. > > > > This necessitated adding _NEW_COLOR. Then I realized > > BRW_NEW_FS_PROG_DATA was just plain missing. > > > Seems like this patch has fallen between the cracks. Can anyone take a > look or let me know if it's no longer applicable. > > Thanks > Emil
Chris and I informally NAK'd it on IRC, sorry. It turns out that render_target_start is always 0, so omitting the bit should be harmless. We thought about sending a patch to delete the field and hardcode 0 instead...
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
