Agreed. I've updated the patch. Thanks. On Mon, Aug 17, 2015 at 11:39 AM, Chad Versace <chad.vers...@intel.com> wrote:
> On Tue 11 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > In agreement with the ASTC spec, this makes calls to TexImage*D > unsuccessful. > > Implied by the spec, Generate[Texture]Mipmap and [Copy]TexSubImage*D > calls > > must be unsuccessful as well. > > > > v2. actually force attempts to compress online to fail. > > v3. indentation (Matt). > > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > I think your patch is missing a needed hunk. The patch updates 3 of the > 5 callers of compressedteximage_only_format to use > _mesa_format_no_online_compression isntead. Here are the 5 callers: > > ✓ texture_error_check (covers glTexImage*D) > ✓ texsubimage_error_check > ✓ copytexsubimage_error_check > ✗ copytexture_error_check (covers glCopyTexImage*D) > ✗ compressed_subtexture_error_check (covers glCompressedTexSubImage*D) > > I think you need to also update copytexture_error_check, because > glCopyTexImage*D is unable copy pixels to an ASTC texture. > > Other than that, this patch looks good to me. Fix that and it's > Reviewed-by: Chad Versace <chad.vers...@intel.com> >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
