On Mon, Aug 17, 2015 at 11:54 AM, Chad Versace <chad.vers...@intel.com> wrote:
> On Tue 28 Jul 2015, Nanley Chery wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > According to the spec, Tex*Storage* commands are supported if the GL > > implementation has support for immutable textures. > > > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > > --- > > src/mesa/main/texformat.c | 56 > +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > This patch's code looks correct to me, but I'm confused by the commit > message. The commit message specifically calls out the glTexStorage* > functions, but _mesa_choose_tex_format() is also used by many other > non-storage glTex* functions. > > Why specifically mention the glTexStorage* function? Is there some > larger context I'm missing? > I called out the glTex*Storage* functions because they were the only commands that wouldn't work correctly during testing. Perhaps I missed some cases (e.g., TextureViews). This patch is superseded by the following patch (which needs review): "mesa/texformat: Use format conversion function in _mesa_choose_tex_format" http://lists.freedesktop.org/archives/mesa-dev/2015-August/091564.html Regards, Nanley
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
