On 08/19/2015 08:51 PM, Matt Turner wrote: > Patches 1 and 6 were too large for the mailing list, so I checked them > in your tree. Patch 6 has some diffs that leave lines badly wrapped: > > + * THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, > + * DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > other than that, all this looks like an improvement to me. > > There are some instances of "VMWARE" and "THE COPYRIGHT OWNER(S) > AND/OR ITS SUPPLIERS" that don't match the license > (http://opensource.org/licenses/MIT) that I think should be changed. > In particular, "VMWARE" is odd since they're not the copyright holder.
I left the odd wrapping on purpose. With the bad wrapping, it makes the diff script show a smaller set of changes in those files relative to the "canonical" license. I thought about putting the odd "DAMAGES OR OTHER" on the previous line, but that would have made it much too long. My real hope is that I can just replace those outliers with the canonical license... leaving the odd wrapping will make that patch smaller. :) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
