On Mon 24 Aug 2015, Nanley Chery wrote: > From: Nanley Chery <nanley.g.ch...@intel.com> > > All compressed formats return GL_FALSE and there isn't any evidence to > support that this behaviour would change. Remove all switch cases for > compressed formats. > > v2. Since the exhaustive switch is removed, add a gtest to ensure > all formats are handled. > v3. Ensure that GL_NO_ERROR is set before returning. > v4. Fix an arg to _mesa_uncompressed_format_to_type_and_comps(); > fix formatting and misc improvements (Chad). > > Cc: Brian Paul <bri...@vmware.com> > Cc: Chad Versace <chad.vers...@intel.com> > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > --- > src/mesa/drivers/dri/i915/intel_pixel_read.c | 2 +- > src/mesa/drivers/dri/i915/intel_tex_image.c | 2 +- > src/mesa/main/formats.c | 58 > ++++++---------------------- > src/mesa/main/formats.h | 2 +- > src/mesa/main/readpix.c | 2 +- > src/mesa/main/tests/mesa_formats.cpp | 9 ++++- > src/mesa/main/texgetimage.c | 2 +- > src/mesa/main/texstore.c | 2 +- > src/mesa/state_tracker/st_cb_readpixels.c | 2 +- > src/mesa/state_tracker/st_cb_texture.c | 6 +-- > src/mesa/state_tracker/st_format.c | 2 +- > src/mesa/swrast/s_drawpix.c | 2 +- > 12 files changed, 31 insertions(+), 60 deletions(-)
v4 is Reviewed-by: Chad Versace <chad.vers...@intel.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev