On Mon, Aug 31, 2015 at 5:28 PM, Marcos Paulo de souza <marcos.souza....@gmail.com> wrote: > > > Em 31-08-2015 13:31, Ilia Mirkin escreveu: >> >> On Mon, Aug 31, 2015 at 12:26 PM, Tobias Klausmann >> <tobias.johannes.klausm...@mni.thm.de> wrote: >>> >>> >>> On 31.08.2015 18:23, Ilia Mirkin wrote: >>>> >>>> On Mon, Aug 31, 2015 at 12:21 PM, Tobias Klausmann >>>> <tobias.johannes.klausm...@mni.thm.de> wrote: >>>>> >>>>> >>>>> On 31.08.2015 17:19, Marcos Paulo de souza wrote: >>>>>> >>>>>> ping :) >>>>>> >>>>>> Em 27-08-2015 12:59, Marcos Paulo de Souza escreveu: >>>>>>> >>>>>>> instead of call prog->getTarget(), since the target never change in >>>>>>> prog. >>>>> >>>>> >>>>> It is not changing now, don't know if it will in the future. Using >>>>> prog->getTarget() may save us from hassling with this piece of code >>>>> again. >>>>> Plus it is more explicit to read in my eyes. >>>> >>>> but... targ gets used *right above* each one of those instances. >>> >>> >>> Kill it alltogether, meaning lets use prog->getTarget() as a default >>> pattern. >> >> Strongly disagree, it's shorter and clearer to just use 'targ' there, >> instead of wondering what it is that prog->getTarget() does. > > To keep everybody happy, maybe we can add some methods in prog and use the > target member of program. > > What do you think?
Like prog->getTarget()? :) I think your patch is fine as-is. I've just been lazy about pushing it since it's pretty minor and doesn't actually fix anything. I'll get around to it. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
