Christoph Brill suggested to CC stable on this patch. On 01/09/15 19:53, Matt Turner wrote: > On Tue, Sep 1, 2015 at 8:02 AM, Alejandro Piñeiro <apinhe...@igalia.com> > wrote: >> The src_reg constructor that received the glsl_type was using it >> only to build the swizzle, but not to fill this->type as dst_reg >> is doing. >> >> This caused some type mismatch between movs and alu operations >> on the NIR path, so copy propagation optimization was not applied >> to remove unneeded movs if negate modifier was involved. This was >> first detected on minus (negate+add) operations. >> >> Shader DB results (taking into account only vec4): >> >> total instructions in shared programs: 20019 -> 19934 (-0.42%) >> instructions in affected programs: 2918 -> 2833 (-2.91%) >> helped: 79 >> HURT: 0 >> GAINED: 0 >> LOST: 0 >> --- > How silly. :) > > Thanks for finding that. > > Reviewed-by: Matt Turner <matts...@gmail.com> >
-- Alejandro Piñeiro (apinhe...@igalia.com) _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
