On 18/09/15 20:00, Jason Ekstrand wrote: > > > On Sep 18, 2015 10:09 AM, "Alejandro Piñeiro" <apinhe...@igalia.com > <mailto:apinhe...@igalia.com>> wrote: > > > > SEL and MOV instructions, as long as they don't have source > modifiers, are > > just copying bits around. So those kind of instruction could be > propagated > > even if there are type mismatches. This is needed because NIR generates > > integer SEL and MOV instructions whenever it doesn't know what else to > > generate. > > > > This commit adds support for copy propagation using current instruction > > as reference. > > > > v2: include check for saturate, as Jason Ekstrand suggested > > v3: check that the dst.type and the src type are the same, in order to > > solve (among others) the following deqp regression with v2: > > > dEQP-GLES3.functional.shaders.operator.unary_operator.minus.lowp_uint_vertex > > Reviewed-by: Jason Ekstrand <jason.ekstr...@intel.com > <mailto:jason.ekstr...@intel.com>> > > The other will take more thinking. >
Taking into account that the second patch is more complex, and probably a new update, I changed my mind, and I think that it would be better to push them individually. I have just pushed this one. Thanks for the review and patience. BR -- Alejandro Piñeiro (apinhe...@igalia.com)
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
