On 28 September 2015 at 14:15, Marek Olšák <mar...@gmail.com> wrote: > On Mon, Sep 28, 2015 at 1:29 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> As the spec allows for {server,client}_wait_sync to be called without >> currently bound context, while our implementation requires context >> pointer. >> >> UNTESTED. >> >> Cc: Chad Versace <chad.vers...@intel.com> >> Cc: Marek Olšák <marek.ol...@amd.com> >> Cc: Chih-Wei Huang <cwhu...@android-x86.org> >> Cc: Mauro Rossi <issor.or...@gmail.com> >> Cc: 10.6 11.0 <mesa-sta...@lists.freedesktop.org> >> Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> >> --- >> >> Upon second thought I'm leaning that we should move this to the API >> specific library (i.e. libEGL) rather than keeping it here. It will give >> us remove API specific from the DRI extension, plus it'll give us better >> mix'n'match (loader+dri module) compatibility. >> >> How do you guys feel on the topic ? > > I don't think there is anything to move into libEGL. st/dri doesn't > add a context pointer to the fence, instead it adds a screen pointer, > which is a different thing. > > This i965 fix is probably not thread-safe, because eglClientWaitSync > can be called from another thread and contexts typically contain no > locks. > Indeed, it's not MT safe. I forgot about the wonders of multithreaded GL.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev