On 11.10.2015 10:11, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com>
The shortlog should say "clean up" (verb) instead of "cleanup" (noun). Same for patches 9 & 10. > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/radeonsi/si_shader.c > index 32a702f..109a805 100644 > --- a/src/gallium/drivers/radeonsi/si_shader.c > +++ b/src/gallium/drivers/radeonsi/si_shader.c > @@ -1306,6 +1306,22 @@ static void si_llvm_init_export_args(struct > lp_build_tgsi_context *bld_base, > unsigned compressed = 0; > unsigned chan; > > + /* XXX: This controls which components of the output > + * registers actually get exported. (e.g bit 0 means export > + * X component, bit 1 means export Y component, etc.) I'm > + * hard coding this to 0xf for now. In the future, we might > + * want to do something else. */ The "*/" should go on its own line. With those fixed, this patch and patches 9 & 10 are Reviewed-by: Michel Dänzer <michel.daen...@amd.com> -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
