On 13 October 2015 at 08:54, Matt Turner <matts...@gmail.com> wrote: > On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd <rhysk...@gmail.com> wrote: > > Signed-off-by: Rhys Kidd <rhysk...@gmail.com> > > --- > > README | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/README b/README > > index 6ed3244..03be4e7 100644 > > --- a/README > > +++ b/README > > @@ -60,6 +60,11 @@ Build with: > > make > > ``` > > > > +run.py relies on a symbolic link to a built piglit bin directory, as > follows: > > +``` > > +ln -s <location_of_piglit>/bin "$PWD"/bin > > +``` > > run.py prints an appropriate message, doesn't it? If we want to do > anything at all, maybe we should just print a more verbose message > from run.py? >
Hello Matt, There is a relevant distinction though here, between a user-reported error (in the general sense) and a user-reported error due to a missing dependency. Having a local built copy of piglit is a dependency of the run.py script, hence why I'm recommending including that fact prominently within README's dependency section per this patch. That said, I'm not wedded to this approach -- so will shortly send out a re-roll of the two patches from this series that aren't upstream to the mailing list for further comment. Regards, Rhys
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
