On Tue, Nov 3, 2015 at 8:07 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 3 November 2015 at 00:29, Matt Turner <matts...@gmail.com> wrote: > >> index 6eeafd5..3d2b051 100644 >> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp >> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp >> @@ -423,7 +423,6 @@ fs_reg::fs_reg(uint8_t vf0, uint8_t vf1, uint8_t vf2, >> uint8_t vf3) >> fs_reg::fs_reg(struct brw_reg reg) : >> backend_reg(reg) >> { >> - this->file = (enum register_file)reg.file; > Should we fold the remaining this->file = foo into the backend_reg() ctors ?
Not necessary. The only remaining file field after this commit is in brw_reg. So the backend_reg(reg) constructor is already doing that. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev