Hi,
I did take a look, and it looks good to me.
I'm happy you implemented DRI_PRIME support as well.
About it, do you need testers to check everything works ?
A mistake about it I noticed is that you don't disable EGL_KHR_image_pixmap
when is_different_gpu is set.
It should be disabled, just like GLX_EXT_texture_from_pixmap is for GLX.
Yours,
Axel Davy
On 10/11/2015 18:30, Martin Peres wrote:
Here is an update to the v3, addressing almost all the comments I got during
the previous round. The one item that is left to do is the handling of
EGL_BUFFER_PRESERVED which will take some time since I need to write a piglit
test for it.
In the mean time, I would really appreciate if you could review the
build-system part since I am not the most familiar with autotools. It seems
like scons is not building the EGL X11 platform, so I did not bother adding
support for the X11 DRI3 there.
I tested the code using GLES apps and ran a full piglit/cts run on all the
platforms. Nothing display-related failed. The only regression visible is
spec/egl_nok_swap_region/basic going from pass to skip as the EGL extension
EGL_NOK_swap_region is not yet implemented. I guess this is OK to work on
that after this series lands.
Boyan Ding (6):
loader: Add dri3 helper
glx/dri3: Convert to use dri3 helper in loader library
egl_dri2: Add a function to let platform code return dri drawable from
_EGLSurface
egl/x11: Implement dri3 support with loader's dri3 helper
loader/dri3: Expose function to create __DRIimage from pixmap
egl/x11_dri3: Implement EGL_KHR_image_pixmap
Martin Peres (1):
egl: make it clear which platform x11 backend is being used (dri2 or
3)
configure.ac | 12 +-
src/egl/Makefile.am | 10 +-
src/egl/drivers/dri2/egl_dri2.c | 118 ++-
src/egl/drivers/dri2/egl_dri2.h | 19 +-
src/egl/drivers/dri2/platform_android.c | 1 +
src/egl/drivers/dri2/platform_drm.c | 1 +
src/egl/drivers/dri2/platform_wayland.c | 2 +
src/egl/drivers/dri2/platform_x11.c | 112 ++-
src/egl/drivers/dri2/platform_x11_dri3.c | 547 ++++++++++++
src/egl/drivers/dri2/platform_x11_dri3.h | 41 +
src/glx/Makefile.am | 2 +
src/glx/dri3_glx.c | 1407 +++---------------------------
src/glx/dri3_priv.h | 94 +-
src/loader/Makefile.am | 15 +-
src/loader/loader_dri3_helper.c | 1396 +++++++++++++++++++++++++++++
src/loader/loader_dri3_helper.h | 241 +++++
16 files changed, 2613 insertions(+), 1405 deletions(-)
create mode 100644 src/egl/drivers/dri2/platform_x11_dri3.c
create mode 100644 src/egl/drivers/dri2/platform_x11_dri3.h
create mode 100644 src/loader/loader_dri3_helper.c
create mode 100644 src/loader/loader_dri3_helper.h
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
