[EMAIL PROTECTED] wrote:
> 
> On 02-Dec-99 [EMAIL PROTECTED] wrote:
> >
> >> It seems to trigger some kind of (FX) Mesa bug
> >> on Win95. Specifically do_normal_transform
> >> gets called with a null value
> >> in ctx->NormalTransform
> 
> Here is the fix for it:
> 
> Index: light.c
> ===================================================================
> RCS file: /cvs/mesa3d/Mesa/src/light.c,v
> retrieving revision 1.8.2.1
> diff -u -r1.8.2.1 light.c
> --- light.c     1999/11/22 19:01:39     1.8.2.1
> +++ light.c     1999/12/02 10:40:00
> @@ -1239,7 +1239,7 @@
>          {
>             ctx->NormalTransform = gl_normal_tab[NORM_NORMALIZE];
>          }
> -        else if (!ctx->Transform.RescaleNormals &&
> +        else if (ctx->Transform.RescaleNormals &&
>                   ctx->rescale_factor != 1.0)
>          {
>             ctx->NormalTransform = gl_normal_tab[NORM_RESCALE];

That's probably not correct.  The code looks odd, but basically what it is saying
is that if we are lighting in object space and not using Rescale, then we have to
introduce the effects of the scale that the normals would have picked up if they
had really been moved to eye space...

I think you are in the right track, but that isn't quite the right fix.

Keith


_______________________________________________
Mesa-dev maillist  -  [EMAIL PROTECTED]
http://lists.mesa3d.org/mailman/listinfo/mesa-dev

Reply via email to