(Reply to all) ----- Forwarded Message ---- From: Keith Whitwell <[EMAIL PROTECTED]> To: "Xiang, Haihao" <[EMAIL PROTECTED]> Sent: Thursday, December 7, 2006 9:25:57 AM Subject: Re: [Mesa3d-dev] Two patches for i965 driver
Haihao, Your analysis is correct - the patch should go in unchanged. I'm a little frustrated regarding getting your CVS/git account set up - have you had any response back from the freedesktop admins? I don't understand why this is taking so long to organize. Keith ----- Original Message ---- From: "Xiang, Haihao" <[EMAIL PROTECTED]> To: Keith Whitwell <[EMAIL PROTECTED]> Cc: Mesa3d-dev@lists.sourceforge.net Sent: Thursday, December 7, 2006 2:27:29 AM Subject: Re: [Mesa3d-dev] Two patches for i965 driver Thanks, Keith. something about the patch for lickering window in upload_drawing_rect function: x1 = dPriv->x; y1 = dPriv->y; x2 = dPriv->x + dPriv->w; y2 = dPriv->y + dPriv->h; In general, (x1, y1) (x2, y2) specify the left-bottom and right-top corner of the window. So in this case(two window are at the same horizontal/vertical), the window under another window will wholly be drawn. and if possible, brw->intel.pClipRects is always updated before uploading. I think (pClipRects[i].x1, pClipRects[i].y1) (pClipRects[i].x2, pClipRects[i].y2) specify the corner of the visible rectangle. In fact the driver uses brw->intel.pClipRect to build DRAWING_RECTANGLE command when there are multiple cliprects. (for example, a window partially covers another window and they are not at the same horizontal/vertical). So I think even if there is only single cliprect, the driver should use pClipRects to build DRAWING_RECTANGLE command. BTW, the driver works well for me if applying this patch. Thanks Haihao On Wed, 2006-12-06 at 07:16 -0800, Keith Whitwell wrote: > The patch for flickering windows looks incorrect - I'll take a closer > look & repost if neccessary. > > The ioctl patch looks good however. > > Keith > > ----- Original Message ---- > From: "Xiang, Haihao" <[EMAIL PROTECTED]> > To: Mesa3d-dev@lists.sourceforge.net > Sent: Wednesday, December 6, 2006 2:31:45 PM > Subject: [Mesa3d-dev] Two patches for i965 driver > > Hi, > > There are two i965 driver patches (see bugzilla), one for bug > 9045 , and another for bug 9237. Can anyone take a look and commit > them? > > > > Any feedback welcome, Thanks in advance > > > > Haihao > > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Mesa3d-dev mailing list > Mesa3d-dev@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mesa3d-dev > > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
