On 5/12/07, Keith Whitwell <[EMAIL PROTECTED]> wrote:
> Oliver McFadden wrote:
> >  src/mesa/drivers/dri/r300/Makefile       |    2 -
> >  src/mesa/drivers/dri/r300/r300_context.c |    2 -
> >  src/mesa/drivers/dri/r300/r300_emit.c    |   49
> ++++++++++++-------------------
> >  src/mesa/drivers/dri/r300/r300_emit.h    |    8 +++++
> >  src/mesa/drivers/dri/r300/r300_maos.h    |   48
> ------------------------------
> >  src/mesa/drivers/dri/r300/r300_render.c  |   16 ----------
> >  src/mesa/drivers/dri/r300/r300_state.c   |   24 +++++++--------
> >  src/mesa/drivers/dri/r300/r300_texmem.c  |   15 +++++----
> >  8 files changed, 50 insertions(+), 114 deletions(-)
> >
> > commit diffs at http://gitweb.freedesktop.org/?p=mesa/mesa.git;a=summary
> >
> > New commits:
> > commit 1b39be3790a093e5b54974221478905b853cadb4
> > Author: Oliver McFadden <[EMAIL PROTECTED]>
> > Date:   Fri May 11 19:44:35 2007 +0000
> >
> >     r300: Removed some checking in r300NumVerts that is not needed.
> >
> >     According to Aapo Tahkola the OpenGL specification defines the
> behaviour when
> >     there are not enough vertices for the primitive type, thus DRI drivers
> do not
> >     need to perform verification on the number of vertices per primitive.
>
> Hmm, not sure who's been saying what, but unless the hardware deals with
>   dropping the extra vertices for you, it is still up to the driver to
> trim them off the end of primitives.
>
> There's a good argument we should do this just once, ie in the vbo/
> module, though.
>
> Keith

Yes, I got the reason wrong in the commit message. However according to the GL
spec I believe this is correct.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to