http://bugs.freedesktop.org/show_bug.cgi?id=12931
Summary: x86[_64] assembly flag check aborts directory build
Product: Mesa
Version: CVS
Platform: x86 (IA32)
OS/Version: Linux (All)
Status: NEW
Severity: minor
Priority: medium
Component: Mesa core
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
Environment:
- Linux kernel 2.6.23.1
- GNU bash, version 3.2.17(1)-release
- GNU Make 3.81
- Mesa git (commit 524c56..., Wed Oct 24 16:36:00 2007) on branch
mesa_7_0_branch
Problem:
When specifying multiple assembly flags in a config file
ASM_FLAGS = -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_SSE_ASM
attempting to build causes the if-blocks in src/mesa/Makefile
@ if [ `echo $(ASM_FLAGS) | grep USE_X86_ASM` ] ; then \
(cd x86 ; $(MAKE)) ; \
fi
@ if [ `echo $(ASM_FLAGS) | grep USE_X86_64_ASM` ] ; then \
(cd x86 ; $(MAKE)) ; \
(cd x86-64 ; $(MAKE)) ; \
fi
to return an error
/bin/sh: line 0: [: -DUSE_MMX_ASM: binary operator expected
which aborts that particular block. This causes the subdirectory not to be
built.
Eventually, the build dies elsewhere at
x86/common_x86_asm.S:42:21: error: matypes.h: No such file or directory
due to the file having not been created in the x86/ directory. It is suspected
(but not tested) that similar problems occur on the 64-bit side of things.
This was believed to be introduced by commit 882ada... on Wed, 24 Oct 2007
22:24:06
Proposed fix:
Remove the unnecessary test and backtick operators to process the return value
from grep directly.
Ex:
@ if echo $(ASM_FLAGS) | grep USE_X86_ASM ; then \
and
@ if echo $(ASM_FLAGS) | grep USE_X86_64_ASM ; then \
Thanks!
-Jason
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev