Jerome Glisse wrote:
> On Sat, 15 Mar 2008 14:55:18 +0100
> Markus Amsler <[EMAIL PROTECTED]> wrote:
> 
>> Well, I know its the same patch for the third time. I still think its 
>> the correct fix if there are unused ATTRIB declarations
>> in the program. Dropping them here relieves the drivers of the burden.
>> The only issue I'm aware of is, that it brings InputsRead and 
>> NumAttributes out of sync. But that's not really a problem since
>> NumAttriubtes is only used in GetProgramivARB. (Besides 
>> Num{Attributes|Instructions|Temproraries|Parameters} is a story for 
>> itself. The specs say unused ones should be counted. Mesa, old fglrx 
>> counts them, nvidia don't and new fglrx counts some.)
>> ---
>>   src/mesa/shader/arbprogparse.c |    7 +++++--
>>   1 files changed, 5 insertions(+), 2 deletions(-)
>>
> 
> I let Brian or Keith or any one more familiar with this aspect
> of the spec to decide or not to push this one :).

Looks good.  Committed.


> Markus i think you should apply for an account you have provided
> several good patch for r300, there is the procedure on fdo.

Yes.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to