On Mon, 2008-03-24 at 03:33 -0700, Keith Whitwell wrote: > > - Commits ----------------------------------------------- > > commit a6d17bf671d6bfbb187a62ba14b9ad08fb5dafe1 > > Author: Michel D채nzer > > Date: Mon Mar 24 09:56:12 2008 +0000 > > > > draw: Fix #include order to fix Linux build. > > Hmm, my preference would be that include order didn't matter... can this be > fixed by changing the headers themselves to #include or define whatever item > was missing? > > What was the failure exactly?
gcc -o build/linux-dri-x86-debug/gallium/auxiliary/draw/draw_pt_elts.os -c -O0 -g3 -Wall -Wmissing-prototypes -Wno-long-long -ffast-math -pedantic -fmessage-length=0 -m32 -fPIC -DDEBUG -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -D_POSIX_SOURCE -D_POSIX_C_SOURCE=199309L -D_SVID_SOURCE -D_BSD_SOURCE -D_GNU_SOURCE -DPTHREADS -DHAVE_POSIX_MEMALIGN -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -Iinclude -Isrc/gallium/include -Isrc/gallium/auxiliary -Isrc/gallium/drivers -I/usr/X11R6/include -I/usr/include/drm src/gallium/auxiliary/draw/draw_pt_elts.c In file included from src/gallium/auxiliary/draw/draw_pt_elts.c:34: src/gallium/auxiliary/draw/draw_pt.h:54: warning: ‘struct draw_pt_middle_end’ declared inside parameter list src/gallium/auxiliary/draw/draw_pt.h:54: warning: its scope is only this definition or declaration, which is probably not what you want src/gallium/auxiliary/draw/draw_pt.h:105: warning: ‘struct draw_context’ declared inside parameter list src/gallium/auxiliary/draw/draw_pt.h:107: warning: ‘struct draw_context’ declared inside parameter list src/gallium/auxiliary/draw/draw_pt.h:112: warning: ‘struct draw_context’ declared inside parameter list In file included from src/gallium/auxiliary/draw/draw_pt_elts.c:35: src/gallium/auxiliary/draw/draw_private.h:71: warning: ISO C90 does not support flexible array members src/gallium/auxiliary/draw/draw_pt_elts.c:61: error: conflicting types for ‘draw_pt_elt_func’ src/gallium/auxiliary/draw/draw_pt.h:105: error: previous declaration of ‘draw_pt_elt_func’ was here src/gallium/auxiliary/draw/draw_pt_elts.c:73: error: conflicting types for ‘draw_pt_elt_ptr’ src/gallium/auxiliary/draw/draw_pt.h:107: error: previous declaration of ‘draw_pt_elt_ptr’ was here scons: *** [build/linux-dri-x86-debug/gallium/auxiliary/draw/draw_pt_elts.os] Error 1 -- Earthling Michel Dänzer | http://tungstengraphics.com Libre software enthusiast | Debian, X and DRI developer ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
