On Mon, 10 Nov 2008 17:08:03 -0500
Zack Rusin <[EMAIL PROTECTED]> wrote:

> On Monday 10 November 2008 16:48:49 Pekka Paalanen wrote:
> >  It looks somehow wrong, and to get it in
> 
> Is there anything in specific that looks wrong with it? It looks right to me.

I was just comparing it to the cso_restore_framebuffer(), but now looking at
cso_*_viewport, you are right.

> 
> > line with the rest of the code, I propose this fix.
> 
> It looks to me like you did the opposite versus the other cso_set functions - 
> we save the passed value as the current state in the context and then set it, 
> you simply made it set the value that is being saved, which since it was just 
> copied is the same. 
> As far as I can see the patch shouldn't have any effect.

Cool, thanks.

Please forget the patch.

-- 
Pekka Paalanen
http://www.iki.fi/pq/

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to