José Fonseca wrote: > On Mon, 2009-03-16 at 06:09 -0700, Michał Król wrote: > >> On Mon, Mar 16, 2009 at 1:59 PM, José Fonseca <jfons...@vmware.com> wrote: >> >>> Shouldn't we use InterlockedIncrement >>> ( http://msdn.microsoft.com/en-us/library/ms683614(VS.85).aspx ) and >>> friends in Windows instead of assembly? It is implemented as a compiler >>> intrinsic, so it probably results in more efficient generated code. >>> >>> >> I am using InterlockedIncrement for windows user subsystem -- see my >> previous commit. (MSCV && X86) seems to have a broader scope than >> WINDOWS_SUBSYSTEM_USER alone. >> > > Sorry. I missed it. Looks good. > > >> What about kernel subsystem? Are there also atomic functions that are >> intrinsic? Anyway, feel free to shuffle #ifdefs around. >> > > The intrinsic are ultimately provided by the compiler. So it should be > possible to use them in the kernel too, regardless of the headers. > > But the only place we care for windows kernel is d3d, and it is single > threaded anyway, so pipe_reference should not use atomic instructions > there anyway. > > Jose > We should perhaps add a non-locked version in the header for windows kernel?
/Thomas ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
