On Fri, 2009-03-20 at 19:23 +0100, Michel Dänzer wrote: > On Fre, 2009-03-20 at 10:45 -0700, Eric Anholt wrote: > > Module: Mesa > > Branch: master > > Commit: 66175aac7609ad314f25fbdff0d3958af310dc24 > > URL: > > http://cgit.freedesktop.org/mesa/mesa/commit/?id=66175aac7609ad314f25fbdff0d3958af310dc24 > > > > Author: Eric Anholt <e...@anholt.net> > > Date: Wed Mar 18 12:07:09 2009 -0700 > > > > Fix DRI2 accelerated EXT_texture_from_pixmap with GL_RGB format. > > > > This requires upgrading the interface so that the argument to > > glXBindTexImageEXT isn't just dropped on the floor. Note that this only > > fixes the accelerated path on Intel, as Mesa's texture format support is > > missing x8r8g8b8 support (right now, GL_RGB textures get uploaded as > > a8r8gb8, > > but in this case we're not doing the upload so we can't really work around > > it > > that way). > > > > Fixes bugs with compositors trying to use shaders that use alpha channels, > > on > > windows without a valid alpha channel. Bug #19910 and likely others as > > well. > > > > Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> > > [...] > > > @@ -239,11 +239,23 @@ struct __DRItexBufferExtensionRec { > > * Method to override base texture image with the contents of a > > * __DRIdrawable. > > * > > - * For GLX_EXT_texture_from_pixmap with AIGLX. > > + * For GLX_EXT_texture_from_pixmap with AIGLX. Deprecated in favor of > > + * setTexBuffer2 in version 2 of this interface > > */ > > void (*setTexBuffer)(__DRIcontext *pDRICtx, > > GLint target, > > __DRIdrawable *pDraw); > > + > > + /** > > + * Method to override base texture image with the contents of a > > + * __DRIdrawable, including the required texture format attribute. > > + * > > + * For GLX_EXT_texture_from_pixmap with AIGLX. > > + */ > > + void (*setTexBuffer2)(__DRIcontext *pDRICtx, > > + GLint target, > > + GLint format, > > + __DRIdrawable *pDraw); > > }; > > Why did you bother sending out the change for public review if you were > only going to take notice of your colleague's ack and ignore suggestions > from others?
I didn't think you were NAKing the patch. I'm not interested in
complicating API so that at some point old API can be removed, when the
overhead of implementing both is so low:
+void
+intelSetTexBuffer(__DRIcontext *pDRICtx, GLint target, __DRIdrawable
*dPriv)
+{
+ /* The old interface didn't have the format argument, so copy our
+ * implementation's behavior at the time.
+ */
+ intelSetTexBuffer2(pDRICtx, target, GLX_TEXTURE_FORMAT_RGBA_EXT,
dPriv);
+}
--
Eric Anholt
e...@anholt.net eric.anh...@intel.com
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
