On Mon, 2009-06-29 at 11:18 -0700, Eric Anholt wrote: > On Mon, 2009-06-29 at 19:11 +0100, Keith Whitwell wrote: > > On Mon, 2009-06-29 at 10:57 -0700, Eric Anholt wrote: > > > Module: Mesa > > > Branch: master > > > Commit: de447afff26706e3bf8bdcd5cfb8b1daf49b4b21 > > > URL: > > > http://cgit.freedesktop.org/mesa/mesa/commit/?id=de447afff26706e3bf8bdcd5cfb8b1daf49b4b21 > > > > > > Author: Eric Anholt <e...@anholt.net> > > > Date: Mon Jun 29 09:48:28 2009 -0700 > > > > > > intel: Remove unneded pthread mutex in LOCK_HARDWARE. > > > > > > This would cause LOCK_HARDWARE to mutex all contexts in this process on > > > both DRI1 and DRI2. On DRI1, LOCK_HARDWARE already does it for all > > > processes on the system. On DRI2, LOCK_HARDWARE doesn't, but there > > > shouldn't > > > be any state outside the context that needs any additional protection. > > > Notably, the bufmgr is protected by its own mutex and not > > > LOCK_HARDWARE. > > > > > > This code was originally introduced with the i915tex code dump, so it's > > > not > > > clear what it was there for. > > > > > > It's there because the DRI1 code doesn't actually achieve the mutexing > > which it looks as if it should. For multi-threaded applications it was > > always possible to get two threads inside locked regions -- I have no > > idea how, but it certainly was and presumably still is possible. > > Sigh, DRI1. I'll put it back under DRI1-only checks. >
Thanks Eric. Keith ------------------------------------------------------------------------------ _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
