tom fogal <[email protected]> writes:
> Chia-I Wu <[email protected]> writes:
> > On Tue, Jul 28, 2009 at 11:10:43AM -0600, tom fogal wrote:
> > > Hrm. I would argue that both places should read something more like:
> > > #if C99 is supported
> > > # include <stdint.h>
> > > #else
> > > /* some typedefs */
> > > #endif
> >
> > I prefer your c99/non-c99 method, both in eglcompiler.h and mesa's
> > main compiler.h. But my concern is that I only have gcc to test.
[snip]
> I'd volunteer to test compiler.h on vs2008 though, and presumably the
> code would be the same in both places so that'd be enough.
FWIW, I've verified that master compiles on vs2005 with:
#if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
# include <stdint.h>
#elif defined(_MSC_VER)
typedef __int8 int8_t;
...
#else
# include <stdint.h>
#endif
in both compiler.h and eglcompiler.h (though I'm not sure I'm
compiling egl). This is the code/approach currently implemented in
eglcompiler.h, as these patches were committed. I do get some link
errors from functions in queryobj.c, but this doesn't seem related -- I
got them 'out of the box' as well.
Cheers,
-tom
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
