Keith Whitwell wrote: > On Wed, 2009-09-02 at 09:12 -0700, Brian Paul wrote: >> Module: Mesa >> Branch: master >> Commit: 4b08e7498230eac30eea1721f33994b30999acd4 >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b08e7498230eac30eea1721f33994b30999acd4 >> >> Author: Brian Paul <[email protected]> >> Date: Wed Sep 2 10:12:15 2009 -0600 >> >> mesa: fix the non-GNU C bit-field case >> >> --- >> >> src/mesa/main/texenvprogram.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/mesa/main/texenvprogram.c b/src/mesa/main/texenvprogram.c >> index b4923e9..165d464 100644 >> --- a/src/mesa/main/texenvprogram.c >> +++ b/src/mesa/main/texenvprogram.c >> @@ -86,8 +86,8 @@ struct mode_opt { >> __extension__ GLubyte Source:4; /**< SRC_x */ >> __extension__ GLubyte Operand:3; /**< OPR_x */ >> #else >> - GLubyte Source; /**< SRC_x */ >> - GLubyte Operand; /**< OPR_x */ >> + GLuint Source; /**< SRC_x */ >> + GLuint Operand; /**< OPR_x */ >> #endif > > Wouldn't it be better to leave these as two (non-bitfield) ubytes? That > way the size would be 2 instead of 8?
Yes, I don't know what I was thinking there. I'll revert that. -Brian ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
