Am Friday 04 September 2009 00:48:19 schrieb Brian Paul: > Michel Dänzer wrote: > > On Thu, 2009-09-03 at 14:43 -0700, Ian Romanick wrote: > >> 2. It becomes increasing difficult to merge (as opposed to cherry-pick) > >> from one branch to the other as the branches diverge. Michel has run > >> into this. > > > > At least in the case I assume you're referring to, it would have been > > more or less the same problem with cherry-picking, as the indentation of > > the GLX code is different between branches. I think the lesson there is > > to resist the temptation of whitespace-only changes, no matter how much > > 'better' the result may appear. > > Funny you should mention whitespace. I've been looking at the radeon > code a bit lately. What a mess. Within a single source file I've > seen 3 different levels of indentation (3/4 space and 8-space tabs). > I'd be happy to see the whole thing run through 'indent'.
I wouldn't. Pauli has posted some indented trees in his Git repository, but that would totally wreak havoc with my development for no good reason. If you feel it is important, we can agree on a whitespace standard once and for all (please don't let it use spaces for indentation [1]) and then make those whitespace changes as we change the code, one patch at a time. But just gratuitously breaking other people's work for no reason is a big no no. cu, Nicolai [1] I can dream, right? ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
