On Fri, 2009-09-04 at 13:01 -0700, Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Brian Paul wrote: > > > I'll fix these. > > > > Perhaps we should prefix or suffix all the lexer tokens with "T_" or > > something like that to avoid collisions. Ian? > > Could we just fix it to not include broken Windows header files?
I doubt. Windows headers have use beyond polluting the global namespace. > They > really assumed nobody would want to use POINT or SIZE in their code? WTF? Why the surprise? It's not just the windows headers, it's the world we live in. As anecdotal example I just saw a build failure because /usr/include/string.h defines a function called "index" -- a single lower case word taken straight from the dictionary. Would you suggest not include the standard C headers too? It's a well known C best practice that any global symbol should have an unique prefix. And in a project of Mesa's dimension it should have become a rule by now. Jose ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
