On Tue, Sep 22, 2009 at 11:28 AM, Zack Rusin <za...@vmware.com> wrote:
> On Tuesday 22 September 2009 14:10:34 Jakob Bornecrantz wrote:
>> diff --git a/src/gallium/state_trackers/xorg/xorg_composite.c
>>  b/src/gallium/state_trackers/xorg/xorg_composite.c index 66ca4cb..ed649a9
>>  100644
>> --- a/src/gallium/state_trackers/xorg/xorg_composite.c
>> +++ b/src/gallium/state_trackers/xorg/xorg_composite.c
>> @@ -359,6 +359,9 @@ bind_framebuffer_state(struct exa_context *exa, struct
>>  exa_pixmap_priv *pDst) state.zsbuf = 0;
>>
>>     cso_set_framebuffer(exa->cso, &state);
>> +
>> +   /* we do fire and forget for the framebuffer, this is the forget part
>>  */ +   pipe_surface_reference(&surface, NULL);
>>  }
>>
>
> This doesn't follow what we do in gallium state trackers. It should be done in
> xorg_exa_common_done called from ExaDone. Or in other words when we're really
> done with the surface.

Right, I'll fix that. I have to admit that I was lazy I couldn't be
bother to figgure where to dereference it properly and it worked for
the i915g driver.

Cheers Jakob.

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to