On Sat, 2009-09-26 at 11:45 -0700, Patrice Mandin wrote: > Hello, > > When I moved the logbase2 function to > src/gallium/auxiliary/util/u_math.h some weeks ago, I did not notice > there was already a similar function there, and also for the is_pot() > flavour: > > line 288: > static INLINE boolean > util_is_power_of_two( unsigned v ) > > line 354: > static INLINE boolean > util_is_pot(unsigned x) > > line 404: > static INLINE unsigned > util_unsigned_logbase2(unsigned n) > > line 463 (this is the one I added): > static INLINE unsigned > util_logbase2(unsigned n)
I'd be glad to see the duplicates gone from master. No particular preference for either. Perhaps shorter is better? Jose ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
