Michel, Is it now possible that drivers that still do a DRI lock/unlock in render_start/render_finish will now do state validation with the incorrect window size?
Is it necessary to have *two* checks for dirty state, before and after the render_start? Keith On Sat, 2009-10-03 at 09:04 -0700, Michel Dänzer wrote: > Module: Mesa > Branch: master > Commit: f741c1eed4559329a89fbf8da569889bbcdace26 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=f741c1eed4559329a89fbf8da569889bbcdace26 > > Author: Michel Dänzer <[email protected]> > Date: Sat Oct 3 18:01:58 2009 +0200 > > swrast: Move up state validation in _swrast_ReadPixels. > > This ensures the driver won't map the wrong set of textures. > > --- > > src/mesa/swrast/s_readpix.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/swrast/s_readpix.c b/src/mesa/swrast/s_readpix.c > index 48b9408..a1aeb2e 100644 > --- a/src/mesa/swrast/s_readpix.c > +++ b/src/mesa/swrast/s_readpix.c > @@ -555,15 +555,15 @@ _swrast_ReadPixels( GLcontext *ctx, > SWcontext *swrast = SWRAST_CONTEXT(ctx); > struct gl_pixelstore_attrib clippedPacking = *packing; > > + if (ctx->NewState) > + _mesa_update_state(ctx); > + > /* Need to do swrast_render_start() before clipping or anything else > * since this is where a driver may grab the hw lock and get an updated > * window size. > */ > swrast_render_start(ctx); > > - if (ctx->NewState) > - _mesa_update_state(ctx); > - > if (swrast->NewState) > _swrast_validate_derived( ctx ); > > > _______________________________________________ > mesa-commit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/mesa-commit ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
