Am Wednesday 14 October 2009 21:15:29 schrieb Brian Paul:
> Nicolai Hähnle wrote:
> > Am Wednesday 14 October 2009 03:45:26 schrieb Brian Paul:
> >> On Mon, Oct 5, 2009 at 9:14 PM, Brian Paul <brian.e.p...@gmail.com>
wrote:
> >>> The texformat-rework branch cleans up the texture format code. The
> >>> gl_texture_format struct is replaced by a simple gl_format enum (see
> >>> formats.h). This leads to assorted clean-ups in core mesa and the
> >>> drivers. This is a step toward unifying and cleaning up the texture
> >>> image and renderbuffer data structures.
> >>>
> >>> There may be some regressions in the tdfx and savage drivers. If/when
> >>> anyone complains I can help diagnose/fix the regressions.
> >>>
> >>> I'd like to merge this branch to master by the end of the week. Let
> >>> me know if there's any concerns.
> >>
> >> I've been too busy to merge this to master, but hopefully soon.
> >>
> >> In the mean time, it'd be great if someone could test this branch with
> >> one of the radeon Rxxx drivers. Everything seems OK with the Intel
> >> drivers and gallium.
> >
> > Just tested on an R300, I get
> >
> > glxgears: main/formats.c:576: _mesa_get_format_bytes: Assertion `info-
> >
> >> BytesPerBlock' failed.
<snip>
> > It may just be an issue of properly guarding the call in the driver, it
> > might also be a sign of something deeper. Unfortunately I don't have the
> > time to investigate right now.
>
> I've just committed a (hopeful) fix.
Thank you; I re-tested, but go another such assertion in Sauerbraten, this
time it seems to be coming from some other source of texture data:
(gdb) bt
#0 0xb7fe1424 in __kernel_vsyscall ()
#1 0xb7bc16d0 in *__GI_raise (sig=6) at
../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2 0xb7bc3098 in *__GI_abort () at abort.c:88
#3 0xb7bba5ce in *__GI___assert_fail (assertion=0xb74a7811 "info-
>BytesPerBlock", file=0xb74a77d6 "main/formats.c", line=576,
function=0xb74a77fa "_mesa_get_format_bytes") at assert.c:78
#4 0xb729117a in _mesa_get_format_bytes (format=MESA_FORMAT_NONE) at
main/formats.c:576
#5 0xb7240d78 in radeon_teximage (ctx=0x85a3e60, dims=2, target=3553,
level=0, internalFormat=6409, width=256, height=256, depth=1,
imageSize=0, format=6409, type=5121, pixels=0xad2fd70, packing=0x85b0da4,
texObj=0x929d540, texImage=0xad00890, compressed=0)
at radeon_texture.c:547
#6 0xb7241447 in radeonTexImage2D (ctx=0x85a3e60, target=3553, level=0,
internalFormat=6409, width=256, height=256, border=0, format=6409,
type=5121, pixels=0xad2fd70, packing=0x85b0da4, texObj=0x929d540,
texImage=0xad00890) at radeon_texture.c:688
#7 0xb72e478b in _mesa_TexImage2D (target=3553, level=0, internalFormat=6409,
width=256, height=256, border=0, format=6409, type=5121,
pixels=0xad2fd70) at main/teximage.c:2316
cu,
Nicolai
> -Brian
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
