Michel Dänzer wrote: > On Wed, 2009-12-02 at 16:21 -0800, Eric Anholt wrote: >> Module: Mesa >> Branch: mesa_7_7_branch >> Commit: 4598942b1b88a2a7d5af7febae7e79eedf00e385 >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=4598942b1b88a2a7d5af7febae7e79eedf00e385 >> >> Author: Eric Anholt <e...@anholt.net> >> Date: Wed Dec 2 13:00:15 2009 -0800 >> >> intel: Make RGB renderbuffers use XRGB8888 like we do for RGB system buffers. >> >> --- >> >> src/mesa/drivers/dri/intel/intel_fbo.c | 6 +----- >> 1 files changed, 1 insertions(+), 5 deletions(-) >> >> diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c >> b/src/mesa/drivers/dri/intel/intel_fbo.c >> index 5615040..b6e0d82 100644 >> --- a/src/mesa/drivers/dri/intel/intel_fbo.c >> +++ b/src/mesa/drivers/dri/intel/intel_fbo.c >> @@ -126,7 +126,7 @@ intel_alloc_renderbuffer_storage(GLcontext * ctx, struct >> gl_renderbuffer *rb, >> case GL_RGB16: >> rb->Format = MESA_FORMAT_ARGB8888; >> rb->DataType = GL_UNSIGNED_BYTE; >> - irb->texformat = MESA_FORMAT_ARGB8888; /* XXX: Need xrgb8888 */ >> + irb->texformat = MESA_FORMAT_XRGB8888; >> cpp = 4; >> break; >> case GL_RGBA: >> @@ -314,10 +314,6 @@ intel_create_renderbuffer(gl_format format) >> irb->Base.DataType = GL_UNSIGNED_BYTE; >> break; >> case MESA_FORMAT_XRGB8888: >> - /* XXX this is a hack since XRGB surfaces don't seem to work >> - * properly yet. Reading the alpha channel returns 0 instead of 1. >> - */ >> - format = MESA_FORMAT_ARGB8888; >> irb->Base._BaseFormat = GL_RGB; >> irb->Base.DataType = GL_UNSIGNED_BYTE; >> break; > > FYI, the second hunk causes a black window with glxgears on my GM45.
That was my experience too when I tried it a few weeks ago. -Brian ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
