On Tuesday 15 December 2009 09:27:04 Keith Whitwell wrote: > On Tue, 2009-12-15 at 06:12 -0800, Zack Rusin wrote: > > The attached patch makes the tgsi assembly parser report, in an > > admittedly rather crude way, the line number at which a syntax error was > > detected. What do you think about that? > > > > z > > Is this the same as the line number printed in TGSI dumps, or different? > > I suspect different, as TGSI doesn't require those line numbers, and > they don't start from the top of the shader. Currently I think they are > only used as labels for CALL and similar opcodes...
yea, they effectively have to be different or otherwise all properties and decelerations are all line -1. > This is confusing but probably unavoidable. I think we may want to look > at labels again and see if we can do better, in which case the line > numbers in TGSI dumps could start from the top of the shader. yea, line numbering is a bit bonkers. we could just do what most other languages does which is have an explicit label statement/instruction. z ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
