On 15.12.2009 14:14, michal wrote: > Guys, > > Does the attached patch make sense to you? > > I replaced the incomplete switch-cases with calls to u_format_access > functions that are complete but are going to be a bit more expensive to > call. Since they are used not very often in mesa state tracker, I > thought it's a good compromise.
They are not only used in state trackers, but drivers for instance as well. That said, it's probably not really a performance critical path. Though I'm not sure it makes sense to keep these functions even around if they'll just do a single function call. Also, I'm pretty sure your usage of the union isn't strict aliasing compliant (as far as I can tell you could just go back and remove that ugly union again), though it's probably one of the cases gcc won't complain (and hopefully won't miscompile). Roland ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
