On Tuesday 19 January 2010 21:42:29 Chia-I Wu wrote: > 2010/1/19 Michel Dänzer <mic...@daenzer.net>: > >> The ximage backend uses only softpipe and that is why I didn't notice > >> that. softpipe seems to work well with permanent pipe transfers, but I > >> think it is vital to use the interface correctly. > > > > If the ximage backend is intrinsically tied to softpipe, it's kind of > > legitimiate for it to rely on softpipe specific transfer semantics if > > that gives a tangible benefit, e.g. by saving transfer > > creation/destruction overhead. > > Yes, that was why it was made permanent. But I am in favor of making the > change to make the pipe transfer temporary right now. I will leave it to > others who concern the performance of ximage backend enough to revert the > change :)
Judging by the confusion, if ximage is to continue relying on softpipe specific behavior, it should probably at least include (more?) comments to that effect - how pipe transfers are normally temporary, but in this case, they're permanent because of (...). Otherwise, it stands as an example of how (not) to do things. While it may be acceptable in this case, it should be made clear that it isn't OK in general. --Kenneth ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
