On 08.02.2010 18:27, Brian Paul wrote: > On Mon, Feb 8, 2010 at 10:21 AM, Roland Scheidegger <srol...@vmware.com> > wrote: >> This branch removes point_size_min and point_size_max because most >> hardware doesn't have any register to clamp this at rasterization time >> (from all gallium drivers, only r300 had this), and the mesa state >> tracker actually never used these field properly. The clamp to >> implementation limits will now be done in the vertex shader instead. >> Also, point_sprite enable is removed and replaced with a >> point_quad_rasterization field. The reason for this is that OGL actually >> has quite different rasterization rules for points and point sprites - >> hence this indicates if points should be rasterized as points or >> according to point sprite (which decomposes them into quads, basically) >> rules. It is unclear to me if we'd actually really need to do something >> different for these rules in the draw module or if hardware can do much >> with this information, but if there's hardware which can well you can >> use it. >> The point sprite coord enable is no longer also indicating the sprite >> coord origin, since there's no api interested in this per coord. >> >> Testing was done with softpipe, and actually pointblast doesn't work >> (does not draw any points at all), neither does spriteblast (some points >> have their size cut somewhere vertically so they are rectangles) >> correctly. However, these bugs are not introduced by this branch, those >> must be bugs in the draw module present before - I'm still trying to >> figure out what goes wrong. > > They're OK on master. I fixed some breakage in this area last week. > See 54d7ec8e769b588ec93dea5bc04399e91737557e for example.
Yes you're right, I missed that (probably because it wasn't in the draw module, but the actual drivers). pointblast works again, and spriteblast actually wasn't broken (parts of points simply disappeared due to depth test...) when cherrypicking those commits to the branch. Roland ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
