On 11.02.2010 22:21, Christoph Bumiller wrote: > On 02/11/2010 10:10 PM, Roland Scheidegger wrote: >> On 11.02.2010 21:42, Christoph Bumiller wrote: >>> On 02/11/2010 09:02 PM, Roland Scheidegger wrote: >>>> Hi, >>>> >>>> could one of the nouveau developers please take a look at the nv30 >>>> changes I did for the stencil ref changes in gallium-dynamicstencilref >>>> branch? >>>> I've just done that in a way I think it might make sense, but I've >>>> absolutely no idea if it would work like that (and even if it would in >>>> theory there might of course still be bugs in it...) >>> Looks like it should work, I can't test nv30 myself though. >>> >>>> Also, I was a bit confused about the so_new() parameters as the numbers >>>> didn't seem to add up (assuming it's basically the max number of >>>> so_method and so_data calls). >>> It's (nr of so_method, nr of so_data + nr of so_reloc, nr of so_reloc), >>> since relocs/addresses are considered data. >> Ok that's what I figured. The numbers were just wrong, then (nv30 used >> 5/21/0 but the actual max was 4/22/0, nv40 uses 4/21/0 and it should >> also be 4/22/0). Hence the confusion. At least things looked ok for nv50 >> (though it seems to needlessly split up the back face state into two >> so_methods - anyway that'll change). >> > Not needlessly - the back stencil methods aren't contiguous, I don't > know why they did that (I just hope we RE'd it correctly).
Ah yes I see now. If I'd have to guess I'd say there might be separate enable bits for bf masks and bf funcs, since certain APIs don't support the former but only the latter, so you would never need to submit bf masks. Doesn't seem to be there, though... And even if you could enable that separately, that still doesn't really explain why bf masks are in a separate place. Anyway, I've updated nv40/nv50 too now. Roland ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
