Yes, from the text you quoted it seems it was indeed incorrect. However, it almost surely ran on any common platform, and the added assert introduced a bug because it would trip for valid usage.
My point is that the incorrectness of the patch (and the fact that the if above that place checking for the variable being non-null was not removed in that same patch) suggests that whether that variable could actually be null or not was not manually evaluated, which, if actually the case, kind of seems to defeat the purpose of doing static analysis in the first place and seems to be counterproductive by possibly hiding errors from further static analysis. Of course, that is not supposed to detract from the appreciation that such code analysis work deserves. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
